Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ci): only publish artifacts on git version tags of main #2360

Open
petermetz opened this issue Mar 31, 2023 · 2 comments
Open

perf(ci): only publish artifacts on git version tags of main #2360

petermetz opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. SPIKE Exploratory work to better scope additional effort

Comments

@petermetz
Copy link
Member

Description

As a maintainer and/or contributor I want to have fast CI cycles so that I'm more productive and the community as a whole is growing faster because the contributions can be accepted at a rapid pace instead of the CI bogging everybody down.

Right now we have a lot of publishing tasks that take up resources (mostly) needlessly because they auto-publish artifacts such as container images and JVM API clients on every merged commit.
This has the negative effect of slowing the CI down overall and also the other negative effect that we are risking hitting limitations on the free tiers that we are using (limits where the number of versions must stay below a certain number for npm packages or container images for example).

One example of this auto-publishing is the kotlin [1] packages and all the other **-publish.yaml files that we have for the container images.

[1] .github/workflows/ghpkg-all-kotlin-api-clients-publish.yaml

Acceptance Criteria

  1. Go through every single .yaml file and produce a list of them which are currently doing auto-publishing on every commit to main
  2. Refactor the list of yaml's obtained in step 1 so that artifact publishing only happens on git tags.
  3. Make sure that the refactor happens in a way that the container image builds are still being tested as part of every PR.
@petermetz petermetz added good-first-issue Good for newcomers SPIKE Exploratory work to better scope additional effort dependencies Pull requests that update a dependency file Developer_Experience Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-400-expert P2 Priority 2: High labels Mar 31, 2023
@petermetz petermetz self-assigned this Mar 31, 2023
@raynatopedrajeta
Copy link

Hello Team,

I was assigned on this task and will start to work on this as of today.

Thanks!

@petermetz
Copy link
Member Author

@raynatopedrajeta Got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. SPIKE Exploratory work to better scope additional effort
Projects
Status: In Progress
Development

No branches or pull requests

2 participants