Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): address Warning: The save-state command is deprecated #2361

Open
petermetz opened this issue Apr 3, 2023 · 4 comments
Open

ci(github): address Warning: The save-state command is deprecated #2361

petermetz opened this issue Apr 3, 2023 · 4 comments
Assignees
@Freedisch
Labels
dependencies Pull requests that update a dependency file good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.

Comments

@petermetz
Copy link
Member

petermetz commented Apr 3, 2023 •
edited

Description

The build-dev job within .github/workflows/ci.yml generates the warning below. We need to address it:

Run actions/cache@v3.0.4
Warning: The `save-state` command is deprecated and will be disabled soon. 
Please upgrade to using Environment Files. For more information see: 
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Acceptance Criteria

  1. Warning is gone
  2. Caching of the build files still works as intended
@petermetz petermetz added good-first-issue Good for newcomers dependencies Pull requests that update a dependency file Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-400-expert Tests Anything related to tests be that automatic or manual, integration or unit, etc. P2 Priority 2: High labels Apr 3, 2023
@petermetz petermetz self-assigned this Apr 3, 2023
@Freedisch
Copy link

@petermetz Hello that seems like a good first issue for me, I could work on that if you don't mind

@petermetz
Copy link
Member Author

@Freedisch Sorry for the very slow response! If you are still interested in solving this then we'd love to have a PR for it! Let me know!

@petermetz petermetz assigned Freedisch and unassigned petermetz Feb 8, 2024
@Freedisch
Copy link

@Freedisch Sorry for the very slow response! If you are still interested in solving this then we'd love to have a PR for it! Let me know!

Got it, on it

@petermetz
Copy link
Member Author

@Freedisch Sorry for the very slow response! If you are still interested in solving this then we'd love to have a PR for it! Let me know!

Got it, on it

@Freedisch Nice! FYI: If you get stuck with anything you can join the daily pair programming calls! More information can be found here: https://wiki.hyperledger.org/display/cactus/Daily+Pair+Programming+Calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freedisch Freedisch

Labels
dependencies Pull requests that update a dependency file good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petermetz @Freedisch