Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-tooling): flag to omit contract deployment in Fabric AIO container #887

Open
petermetz opened this issue Apr 29, 2021 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file Developer_Experience Fabric good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone

Comments

@petermetz
Copy link
Member

Description

As a developer I want to be able to use the Fabric AIO container for rapid prototyping so that I'm more productive while working on a chain code contract with Cactus.

Right now the Fabric AIO container always goes through the deployment of the default basic asset transfer contract which takes time before the health check starts passing.

What we could do is add an environment variable that the container checks for and based on that it omits the deployment of the default contract to speed things up.

Acceptance Criteria

  1. Flag to control whether the deployment of the default contract happens or not.
  2. At least one test verifying the working of the flag
  3. The container health check is updated so that it does not rely on the default contract anymore where not applicable (e.g. if the flag from 1) was set)
  4. Health check must still be a reliable indicator of the ledger being up and running otherwise we'll have a bunch of flaky tests on our hands right after merging this change.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy

@petermetz petermetz added Fabric dependencies Pull requests that update a dependency file Developer_Experience labels Apr 29, 2021
@petermetz petermetz added this to the v0.5.0 milestone Apr 29, 2021
@petermetz petermetz modified the milestones: v0.5.0, v0.6.0 May 19, 2021
@petermetz petermetz modified the milestones: v0.6.0, v0.7.0 Jul 20, 2021
@petermetz petermetz modified the milestones: v0.7.0, v0.8.0 Aug 10, 2021
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Sep 2, 2021
@petermetz petermetz added the Tests Anything related to tests be that automatic or manual, integration or unit, etc. label Nov 17, 2021
@petermetz petermetz self-assigned this Aug 20, 2023
@petermetz petermetz modified the milestones: v0.10.0, vT.B.D Aug 20, 2023
@petermetz petermetz added P3 Priority 3: Medium good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Developer_Experience Fabric good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Development

No branches or pull requests

1 participant