Skip to content

Commit

Permalink
fix(connector-corda): kotlin compilation error due to missing method
Browse files Browse the repository at this point in the history
When we added the prometheus monitoring endpoint to the
OpenAPI spec, the kotlin implementation was not updated
and this has lead to the container image build process failing
which was not noticed because currently the GHA CI does not
build the container images and therefore you can get away
with introducing issues to the container image build.
(this is soon to be rectified)

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Jul 7, 2021
1 parent 341cffc commit 403f135
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class ApiPluginLedgerConnectorCordaServiceImpl(
// org.hyperledger.cactus.plugin.ledger.connector.corda.server.model.InvokeContractV1Response["returnValue"]->
// net.corda.client.jackson.internal.StxJson["wire"]->net.corda.client.jackson.internal.WireTransactionJson["outputs"])]
// with root cause
return InvokeContractV1Response(true, id.toString(), (returnValue as SignedTransaction).id, progress)
return InvokeContractV1Response(true, id.toString(), (returnValue as SignedTransaction).id.toString(), progress)
}

// FIXME - make it clear in the documentation that this deployment endpoint is not recommended for production
Expand Down Expand Up @@ -279,6 +279,10 @@ class ApiPluginLedgerConnectorCordaServiceImpl(
return DiagnoseNodeV1Response(nodeDiagnosticInfo = nodeDiagnosticInfoCactus)
}

override fun getPrometheusExporterMetricsV1(): String {
TODO("Not yet implemented")
}

override fun invokeContractV1(invokeContractV1Request: InvokeContractV1Request?): InvokeContractV1Response {
Objects.requireNonNull(invokeContractV1Request, "InvokeContractV1Request must be non-null!")
return dynamicInvoke(rpc.proxy, invokeContractV1Request!!)
Expand Down

0 comments on commit 403f135

Please sign in to comment.