Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cactus-plugin-keychain-vault): Implement tests for openapi validation #1329

Closed
elenaizaguirre opened this issue Sep 14, 2021 · 0 comments · Fixed by #1330
Closed

fix(cactus-plugin-keychain-vault): Implement tests for openapi validation #1329

elenaizaguirre opened this issue Sep 14, 2021 · 0 comments · Fixed by #1330
Assignees
@elenaizaguirre
Labels
bug Something isn't working Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@elenaizaguirre
Copy link
Contributor

Describe the bug

After implement openapi validation in plugins endpoints in cmd-api-server (#847), we must ensure that all endpoints in cactus-plugin-keychain-vault are validated according package openapi specs.

Specific tests are needed.

To Reproduce

Call endpoints throught package API client with right and wrong requests.

Expected behavior

Right requests should return status code 200 and wrong requests should return status code 400.

Hyperledger Cactus Plugins/Connectors Used

  • cactus-plugin-keychain-vault
@elenaizaguirre elenaizaguirre added the bug Something isn't working label Sep 14, 2021
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Sep 14, 2021
@elenaizaguirre
fix: openapi validation test for keychain-vault plugin
a6ff1ab 
Includes tests for endpoints setKeychainEntryV1,
getKeychainEntryV1, deleteKeychainEntryV1 and
hasKeychainEntryV1, each of them, when appropiate,
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger#1329

Relationed with hyperledger#847

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
@elenaizaguirre elenaizaguirre mentioned this issue Sep 14, 2021
Merged
@petermetz petermetz added the Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. label Sep 14, 2021
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Sep 17, 2021
@elenaizaguirre
fix: openapi validation test for keychain-vault plugin
4735ceb 
Includes tests for endpoints setKeychainEntryV1,
getKeychainEntryV1, deleteKeychainEntryV1 and
hasKeychainEntryV1, each of them, when appropiate,
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger#1329

Relationed with hyperledger#847

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
petermetz pushed a commit that referenced this issue Sep 18, 2021
@elenaizaguirre @petermetz
fix: openapi validation test for keychain-vault plugin
6630ebe 
Includes tests for endpoints setKeychainEntryV1,
getKeychainEntryV1, deleteKeychainEntryV1 and
hasKeychainEntryV1, each of them, when appropiate,
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes #1329

Relationed with #847

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
izuru0 pushed a commit to izuru0/cactus that referenced this issue Oct 1, 2021
@elenaizaguirre @izuru0
fix: openapi validation test for keychain-vault plugin
f6a85fd 
Includes tests for endpoints setKeychainEntryV1,
getKeychainEntryV1, deleteKeychainEntryV1 and
hasKeychainEntryV1, each of them, when appropiate,
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger#1329

Relationed with hyperledger#847

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
brioux pushed a commit to brioux/cactus that referenced this issue Oct 4, 2021
@elenaizaguirre @brioux
fix: openapi validation test for keychain-vault plugin
a53e084 
Includes tests for endpoints setKeychainEntryV1,
getKeychainEntryV1, deleteKeychainEntryV1 and
hasKeychainEntryV1, each of them, when appropiate,
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger#1329

Relationed with hyperledger#847

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@elenaizaguirre @RafaelAPB
fix: openapi validation test for keychain-vault plugin
1d48039 
Includes tests for endpoints setKeychainEntryV1,
getKeychainEntryV1, deleteKeychainEntryV1 and
hasKeychainEntryV1, each of them, when appropiate,
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger#1329

Relationed with hyperledger#847

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elenaizaguirre elenaizaguirre

Labels
bug Something isn't working Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: openapi validation test for keychain-vault plugin elenaizaguirre/cactus
2 participants
@petermetz @elenaizaguirre