fix(cmd-api-server): build occasionally broken - protoc-gen-ts #1563
Assignees
Labels
API_Server
bug
Something isn't working
dependencies
Pull requests that update a dependency file
Developer_Experience
Comments
petermetz
added
API_Server
bug
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Nov 23, 2021
…edger#1563 Upgrading protoc-gen-ts from 0.4.0 to 0.6.0 instantly fixed the issue while I had it in a reproduced state (e.g. my build was broken on main) This is not necessarily evidence that the fix is legit, but it's most likely a step in the right direction and there's also the possibility that this is the actual fix. It would take too much time to properly debug if it really is the fix, so I'll just give it the benefit of the doubt for now and assume that it is. Fixes hyperledger#1563 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Nov 27, 2021
…edger#1563 Upgrading protoc-gen-ts from 0.4.0 to 0.6.0 instantly fixed the issue while I had it in a reproduced state (e.g. my build was broken on main) This is not necessarily evidence that the fix is legit, but it's most likely a step in the right direction and there's also the possibility that this is the actual fix. It would take too much time to properly debug if it really is the fix, so I'll just give it the benefit of the doubt for now and assume that it is. Also had to upgrade the @types/google-protobuf package to a newer version because it didn't have the deserializeBinary() method defined on the custom made Map type that ships with the PB compiler and this was causing the generated Typescript code to not compile. Fixes hyperledger#1563 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this issue
Nov 28, 2021
Upgrading protoc-gen-ts from 0.4.0 to 0.6.0 instantly fixed the issue while I had it in a reproduced state (e.g. my build was broken on main) This is not necessarily evidence that the fix is legit, but it's most likely a step in the right direction and there's also the possibility that this is the actual fix. It would take too much time to properly debug if it really is the fix, so I'll just give it the benefit of the doubt for now and assume that it is. Also had to upgrade the @types/google-protobuf package to a newer version because it didn't have the deserializeBinary() method defined on the custom made Map type that ships with the PB compiler and this was causing the generated Typescript code to not compile. Fixes #1563 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Sometimes when I switch to the main branch and do a
yarn configureit endsTo Reproduce
Switch branches, do rebuilds (a lot) because of working on a bunch of different things simultaneously + reviewing PRs and then it will probably happen around once a week that the build fails because the codegen script bugged out and forgot to generate the Typescript implementation files from the protocol buffers of the API server and you are getting errors from the tsc script because it's missing the TS source code it needs to compile everything.
Expected behavior
Build is stable.
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
1.0.0-rc.2Hyperledger Cactus Plugins/Connectors Used
N/A
Additional context
This has been around for a while and I'm suspicious that it's a bug with
protoc-gen-tsitself so the first step would be to try and upgrade that and see if it fixes the problem.The text was updated successfully, but these errors were encountered: