Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): build re-touches unused git_push.sh file #212

Closed
petermetz opened this issue Jun 27, 2020 · 0 comments · Fixed by #213
Closed

fix(sdk): build re-touches unused git_push.sh file #212

petermetz opened this issue Jun 27, 2020 · 0 comments · Fixed by #213
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers Nice-to-Have

Comments

@petermetz
Copy link
Member

Describe the bug

The SDK build touches the packages/cactus-sdk/src/main/typescript/generated/openapi/typescript-axios/git_push.sh file which then shows up in the git diffs despite the file contents being equal as before (maybe it changes the executable flag on the file?)

The second part of the problem is that we don't actually use/need/want this git_push.sh file at all since we have our own mechanisms in place for doing what that (otherwise handy little) script does for developers. So really the best would be to just ignore/exclude/delete that file altogether.

To Reproduce

npm run build or any of the lighter build tasks that still end up running the OpenAPI generator tool for the SDK.
Run git status and notice how the file was touched and that there is no real diff.

Expected behavior

The build should not touch files that are under version control, or if it does, there should be an actual change to propagate.

Operating system name, version, build:

Use this command: printf "$(uname -srm)\n$(cat /etc/os-release)\n"

Linux 5.4.0-39-generic x86_64
NAME="Ubuntu"
VERSION="20.04 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

92e7b0b

Hyperledger Cactus Plugins/Connectors Used

Additional context

Fairly certain that the root cause is the OpenAPI generator doing something it should not (or something that is needed but we don't use it).

cc: @takeutak @jonathan-m-hamilton @sfuji822

@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers Nice-to-Have dependencies Pull requests that update a dependency file Developer_Experience labels Jun 27, 2020
@petermetz petermetz self-assigned this Jun 27, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Jun 27, 2020
fixes hyperledger#212

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Jun 30, 2020
fixes #212

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers Nice-to-Have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant