Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): servers utility class for HTTP/S #267

Closed
petermetz opened this issue Aug 27, 2020 · 0 comments · Fixed by #276
Closed

feat(common): servers utility class for HTTP/S #267

petermetz opened this issue Aug 27, 2020 · 0 comments · Fixed by #276
Assignees
@petermetz
Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers

Comments

@petermetz
Copy link
Member

Description

As a developer who works a lot on different plugins that expose web services I want to have a utility class starting/shutting down HTTP/S servers in a promisifed way so that I can start/shutdown a server as needed with one-liners instead of 15 lines of callback hell.

There is already a ./common/servers.ts file in the api server package but that should be moved to the common package instead and be extended with some additional functionality.

Acceptance Criteria

  1. Move Servres class to common package
  2. Make sure to only export the Servers class for the node builds never the web ones.

cc: @jonathan-m-hamilton @takeutak @sfuji822
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers Developer_Experience labels Aug 27, 2020
@petermetz petermetz self-assigned this Aug 27, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Sep 5, 2020
@petermetz
feat(common): Servers utility class
d3563b7 
Useful when working with HTTP servers especially for
test case authoring where there's a lot of server
creation for the purpose of allocating random ports
prior to launching an API server instance.

Fixes hyperledger#260
Fixes hyperledger#267

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Sep 5, 2020
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Sep 17, 2020
@petermetz
feat(common): Servers utility class
d7fadb2 
Useful when working with HTTP servers especially for
test case authoring where there's a lot of server
creation for the purpose of allocating random ports
prior to launching an API server instance.

Fixes hyperledger#260
Fixes hyperledger#267

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Sep 17, 2020
@petermetz
feat(common): Servers utility class
ad01dee 
Useful when working with HTTP servers especially for
test case authoring where there's a lot of server
creation for the purpose of allocating random ports
prior to launching an API server instance.

Fixes #260
Fixes #267

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(common): Servers utility class petermetz/cacti
1 participant
@petermetz