Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd-api-server): bundle name typos #376

Closed
petermetz opened this issue Nov 9, 2020 · 0 comments · Fixed by #377
Closed

fix(cmd-api-server): bundle name typos #376

petermetz opened this issue Nov 9, 2020 · 0 comments · Fixed by #377
Assignees
@petermetz
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@petermetz
Copy link
Member

Describe the bug

Currently the package.json declares the bundle names incorrectly (copy paste mistake most likely)

  "main": "dist/cactus-core-api.node.umd.js",
  "mainMinified": "dist/cactus-core-api.node.umd.min.js",
  "browser": "dist/cactus-core-api.web.umd.js",
  "browserMinified": "dist/cactus-core-api.web.umd.min.js",

The correct values would be:

  "main": "dist/cactus-cmd-api-server.node.umd.js",
  "mainMinified": "dist/cactus-cmd-api-server.node.umd.min.js",
  "browser": "dist/cactus-cmd-api-server.web.umd.js",
  "browserMinified": "dist/cactus-cmd-api-server.web.umd.min.js",

To Reproduce

Clone the project, open the file ./packages/cactus-cmd-api-server/package.json
and observe the contents as explained above.

Expected behavior

./packages/cactus-cmd-api-server/package.json declares the bundle names correctly.

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

v0.2.0
@petermetz petermetz added the bug Something isn't working label Nov 9, 2020
@petermetz petermetz added this to the v0.2.0 milestone Nov 9, 2020
@petermetz petermetz self-assigned this Nov 9, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Nov 9, 2020
@petermetz
fix(cmd-api-server): bundle name typos
f604dc6 
Fixes hyperledger#376

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Nov 9, 2020
Merged
petermetz added a commit that referenced this issue Nov 10, 2020
@petermetz
fix(cmd-api-server): bundle name typos
711ad71 
Fixes #376

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
sandeepnRES added a commit to sandeepnRES/cacti that referenced this issue Feb 9, 2023
@sandeepnRES
Merge pull request hyperledger#376 from sanvenDev/main
b6e9cb4 
Fix Readme Instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

fix(cmd-api-server): bundle name typos petermetz/cacti
1 participant
@petermetz