Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector-besu): revert manual change in generated code #453

Closed
petermetz opened this issue Jan 6, 2021 · 1 comment · Fixed by #454 or #592
Closed

fix(connector-besu): revert manual change in generated code #453

petermetz opened this issue Jan 6, 2021 · 1 comment · Fixed by #454 or #592
Assignees
Labels
bug Something isn't working
Milestone

Comments

@petermetz
Copy link
Member

Describe the bug

The api.ts file of the besu connector package has a manual change in it that was not coming from a change in the openapi spec ts file.

To Reproduce

Open the mentioned file.
Perform a clean build.
Observe that your git index is no longer empty because the generator restored the state of the api.ts file (e.g. erased the manual change)

Expected behavior

Whenever the build runs, there should NOT be any files changing under source control (only exception is when issuing releases)

cc: @sfuji822 @hartm @takeutak @jonathan-m-hamilton

@petermetz petermetz added the bug Something isn't working label Jan 6, 2021
@petermetz petermetz added this to the v0.4.0 milestone Jan 6, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Jan 6, 2021
This must've slipped in during a recent refactor.

Fixes hyperledger#453
petermetz added a commit to petermetz/cacti that referenced this issue Jan 6, 2021
This must've slipped in during a recent refactor.

Fixes hyperledger#453

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jan 6, 2021
This must've slipped in during a recent refactor.

Fixes hyperledger#453

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Jan 8, 2021
This must've slipped in during a recent refactor.

Fixes #453

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@AzaharaC
Copy link
Contributor

Working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants