Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): clean script del-cli syntax #469

Closed
petermetz opened this issue Jan 13, 2021 · 0 comments · Fixed by #470
Closed

fix(npm): clean script del-cli syntax #469

petermetz opened this issue Jan 13, 2021 · 0 comments · Fixed by #470
Assignees
@petermetz
Labels
bug Something isn't working
Milestone
v0.4.0

Comments

@petermetz
Copy link
Member

Describe the bug

  1. The clean script does not clean all dist directories properly with the current way of it being invoked through lerna
  2. Also, it only cleans the generated typescript code for the api-client package, but not for all the other packages that have generated typescript code as well.

To Reproduce

Run the clean script and observe that build artifacts remain in place.

Expected behavior

When I run clean I want all the build artifacts to be gone.

Cloud provider or hardware configuration:

Dev machine.

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

v0.3.0

cc: @sfuji822 @takeutak @hartm @jonathan-m-hamilton
@petermetz petermetz added the bug Something isn't working label Jan 13, 2021
@petermetz petermetz added this to the v0.4.0 milestone Jan 13, 2021
@petermetz petermetz self-assigned this Jan 13, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Jan 13, 2021
@petermetz
fix(npm): clean script was missing folders
4eb4222 
1. No longer uses lerna and instead specifies glob patterns
2. Expands the deletion of generated Typescript code to all
packages where it's present not just the api-client package.

Fixes hyperledger#469

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jan 13, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Jan 13, 2021
@petermetz
fix(npm): clean script was missing folders
cd7d4f7 
1. No longer uses lerna and instead specifies glob patterns
2. Expands the deletion of generated Typescript code to all
packages where it's present not just the api-client package.
3. Deletes the two files that were meant to be deleted to
begin with, but since the clean script was not fully working
they were actually left undeleted until now.

Fixes hyperledger#469

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Jan 14, 2021
@petermetz
fix(npm): clean script was missing folders
416b82e 
1. No longer uses lerna and instead specifies glob patterns
2. Expands the deletion of generated Typescript code to all
packages where it's present not just the api-client package.
3. Deletes the two files that were meant to be deleted to
begin with, but since the clean script was not fully working
they were actually left undeleted until now.

Fixes #469

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

fix(npm): clean script was missing folders petermetz/cacti
1 participant
@petermetz