Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): missing uuid from plugins #529

Closed
petermetz opened this issue Feb 3, 2021 · 0 comments · Fixed by #530
Closed

fix(deps): missing uuid from plugins #529

petermetz opened this issue Feb 3, 2021 · 0 comments · Fixed by #530
Assignees
Labels
bug Something isn't working
Milestone

Comments

@petermetz
Copy link
Member

Describe the bug

The uuid package is being used by two plugin packages while it not being declared as a dependency. (it works for tests because the uuid package is also a dependency in the parent package most likely so node's module resolution algorithm ends up finding it when there's a ./node_modules directory present in the project root with the dependencies installed.

To Reproduce

Open these files and observe the lack of uuid dependency:

./packages/cactus-plugin-consortium-manual/package.json
./packages/cactus-plugin-keychain-memory/package.json

Expected behavior

uuid should be a dependency in these packages since they use it as an import.

Cloud provider or hardware configuration:

Inside a docker container running on a dev machine.

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main

Hyperledger Cactus Plugins/Connectors Used

./packages/cactus-plugin-consortium-manual/package.json
./packages/cactus-plugin-keychain-memory/package.json

Additional context

This came up while containerizing the supply-chain-app example where we had to delete the root folder's node_modules directory while trying to reduce the image size from the initial 3 GB (yikes).
After having deleted said directory the uuid module failed to resolve in the mentioned packages which is how this bug was discovered.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jagpreetsinghsasan @jordigiam @kikoncuo

@petermetz petermetz added the bug Something isn't working label Feb 3, 2021
@petermetz petermetz added this to the v0.4.0 milestone Feb 3, 2021
@petermetz petermetz self-assigned this Feb 3, 2021
petermetz pushed a commit to petermetz/cacti that referenced this issue Feb 3, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Fixes hyperledger#529
petermetz pushed a commit to petermetz/cacti that referenced this issue Feb 3, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Fixes hyperledger#529
petermetz pushed a commit to petermetz/cacti that referenced this issue Feb 3, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Fixes hyperledger#529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Feb 3, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Fixes #529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
(cherry picked from commit 0fbdd44)
petermetz added a commit to petermetz/cacti that referenced this issue Feb 3, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Also updates the import syntax in
packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-node-jws-endpoint-v1.ts
which appears to make a difference?

Fixes hyperledger#529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Feb 3, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Also updates the import syntax in
packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-node-jws-endpoint-v1.ts
which appears to make a difference?

Fixes #529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
(cherry picked from commit 0308dd8)
petermetz added a commit that referenced this issue Feb 7, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Also updates the import syntax in
packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-node-jws-endpoint-v1.ts
which appears to make a difference?

Fixes #529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue Feb 11, 2021
Adds the missing dependency "uuid" to the packages where applicable.

Also updates the import syntax in
packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-node-jws-endpoint-v1.ts
which appears to make a difference?

Fixes hyperledger#529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant