Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-vault): add prometheus metrics support to the OpenAPI specs of the plugin #536

Closed
jagpreetsinghsasan opened this issue Feb 4, 2021 · 1 comment · Fixed by #659
Closed

feat(keychain-vault): add prometheus metrics support to the OpenAPI specs of the plugin #536

jagpreetsinghsasan opened this issue Feb 4, 2021 · 1 comment · Fixed by #659
Assignees
@jagpreetsinghsasan
Labels
API_Server enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to integrate Prometheus Exporter for the Keychain Vault Cactus plugin, Issue #458 details the description in depth and covers up for all the underlying plugins.

cc: @petermetz @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers API_Server Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Feb 5, 2021
@jagpreetsinghsasan
Copy link
Contributor Author

The integration test case is commented for this plugin.
I tried uncommenting it out and modified some code
image
And the code fails at line 67 in the above mentioned screenshot.

jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Mar 17, 2021
@jagpreetsinghsasan
feat(keychain-vault): add prometheus exporter
aecb335 
	Primary Change
	--------------

	1. The keychain-vault plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IPluginKeychainVaultOptions interface in PluginKeychainVault class now has a prometheusExporter optional field
	5. The PluginKeychainMemory class has relevant functions and codes to incorporate prometheus exporter
	6. Added Readme.md on the prometheus exporter usage

	Fixes hyperledger#536

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Mar 17, 2021
Merged
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Mar 17, 2021
@jagpreetsinghsasan
feat(keychain-vault): add prometheus exporter
b9fe98b 
	Primary Change
	--------------

	1. The keychain-vault plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IPluginKeychainVaultOptions interface in PluginKeychainVault class now has a prometheusExporter optional field
	5. The PluginKeychainMemory class has relevant functions and codes to incorporate prometheus exporter
	6. Added Readme.md on the prometheus exporter usage

	Fixes hyperledger#536

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit that referenced this issue Mar 23, 2021
@jagpreetsinghsasan @petermetz
feat(keychain-vault): add prometheus exporter
fea547f 
	Primary Change
	--------------

	1. The keychain-vault plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IPluginKeychainVaultOptions interface in PluginKeychainVault class now has a prometheusExporter optional field
	5. The PluginKeychainMemory class has relevant functions and codes to incorporate prometheus exporter
	6. Added Readme.md on the prometheus exporter usage

	Fixes #536

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue Apr 8, 2021
@jagpreetsinghsasan
feat(keychain-vault): add prometheus exporter
9f4dd45 
	Primary Change
	--------------

	1. The keychain-vault plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IPluginKeychainVaultOptions interface in PluginKeychainVault class now has a prometheusExporter optional field
	5. The PluginKeychainMemory class has relevant functions and codes to incorporate prometheus exporter
	6. Added Readme.md on the prometheus exporter usage

	Fixes hyperledger#536

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
API_Server enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(keychain-vault): add prometheus exporter jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan