Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-client): flaky DefaultConsortiumProvider test #605

Closed
petermetz opened this issue Feb 26, 2021 · 0 comments · Fixed by #607
Closed

fix(api-client): flaky DefaultConsortiumProvider test #605

petermetz opened this issue Feb 26, 2021 · 0 comments · Fixed by #607
Labels
bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.

Comments

@petermetz
Copy link
Member

Describe the bug

There's this one test that I've seen the second time failing now (and it's a fluke with a timeout).

To Reproduce

It's random so no repro steps.

Expected behavior

Tests should be consistent.

Logs/Stack traces

https://github.com/hyperledger/cactus/pull/602/checks?check_run_id=1985681878#step:10:27

Screenshots

N/A

Cloud provider or hardware configuration:

GitHub Action Execution environment. Never seen it on my dev machines.

Operating system name, version, build:

See the ci.yml file for the OS details.

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main

Hyperledger Cactus Plugins/Connectors Used

The manual consortium management plugin.

Additional context

There is a test that uses a timeout to assert whether something was successful or not. Currently this timeout is a 100ms which appears to be too low nowadays (could indicate that our GH actions are getting less CPU power than before?).
Likely just a matter of bumping up the timeout to 10x or 100x the current value, but would be nice if the need for the timeout could be completely eliminated (while preserving the test case and the assertions themselves of course).

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo

@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Feb 26, 2021
@petermetz petermetz changed the title fix: flaky CI fix(api-client): flaky test for DefaultConsortiumProvider Feb 26, 2021
@petermetz petermetz changed the title fix(api-client): flaky test for DefaultConsortiumProvider fix(api-client): flaky DefaultConsortiumProvider test Feb 26, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 1, 2021
Fixes hyperledger#605

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Mar 1, 2021
Fixes #605

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant