Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(corda-connector): node diagnostics endpoint #623

Closed
petermetz opened this issue Mar 2, 2021 · 0 comments · Fixed by #657
Closed

feat(corda-connector): node diagnostics endpoint #623

petermetz opened this issue Mar 2, 2021 · 0 comments · Fixed by #657
Assignees
Labels
Corda enhancement New feature or request

Comments

@petermetz
Copy link
Member

Is your feature request related to a problem? Please describe.

The Corda RPC proxy has a diagnostics method that we need to expose as an endpoint for our own connector as well.
This will help tremendously in debugging things when people are working with the corda connector (speaking from experience here).

Describe the solution you'd like

Just a run of the mill endpoint exposing the RPC proxy's diagnostic method's return value as it's own response.

Describe alternatives you've considered

Nothing. I'm pretty sure we need this and that this is the simplest possible way of achieving it.

Additional context

N/A

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo

@petermetz petermetz added Corda enhancement New feature or request labels Mar 2, 2021
@petermetz petermetz self-assigned this Mar 2, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 10, 2021
The Corda RPC proxy has a diagnostics method that we
exposed here as an endpoint for our own connector as well.
This will help tremendously in debugging things when
people are working with the corda connector
(speaking from experience here).

Fixes hyperledger#623

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 11, 2021
Primary change
-------------

The Corda RPC proxy has a diagnostics method that we
exposed here as an endpoint for our own connector as well.
This will help tremendously in debugging things when
people are working with the corda connector
(speaking from experience here).

Fixes hyperledger#623

Secondary change(s)
-------------------

1. Updated the jvm-kotlin-spring-server test case
to use the container images from the official repository
instead of relying on the temporary ones from Peter's
personal one.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Mar 23, 2021
Primary change
-------------

The Corda RPC proxy has a diagnostics method that we
exposed here as an endpoint for our own connector as well.
This will help tremendously in debugging things when
people are working with the corda connector
(speaking from experience here).

Fixes #623

Secondary change(s)
-------------------

1. Updated the jvm-kotlin-spring-server test case
to use the container images from the official repository
instead of relying on the temporary ones from Peter's
personal one.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue Apr 8, 2021
Primary change
-------------

The Corda RPC proxy has a diagnostics method that we
exposed here as an endpoint for our own connector as well.
This will help tremendously in debugging things when
people are working with the corda connector
(speaking from experience here).

Fixes hyperledger#623

Secondary change(s)
-------------------

1. Updated the jvm-kotlin-spring-server test case
to use the container images from the official repository
instead of relying on the temporary ones from Peter's
personal one.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Corda enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant