Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools): prod build fail due to missing dependency ngo #673

Closed
petermetz opened this issue Mar 16, 2021 · 0 comments · Fixed by #674
Closed

fix(tools): prod build fail due to missing dependency ngo #673

petermetz opened this issue Mar 16, 2021 · 0 comments · Fixed by #674
Assignees
@petermetz
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience Fabric good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.

Comments

@petermetz
Copy link
Member

Describe the bug

The production build (that does webpack bundling) fails due to the missing ngo dependency from the fabric connector. This was mistakenly removed at the time of a cleanup 5 months ago.

To Reproduce

./tools/ci.sh and watch it burn

Expected behavior

./tools/ci.sh and watch it succeed.

Logs/Stack traces

N/A

Screenshots

N/A

Cloud provider or hardware configuration:

Dev machine

Operating system name, version, build:

$ printf "$(uname -srm)\n$(cat /etc/os-release)\n"
Linux 5.8.0-44-generic x86_64
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main @ ebfff9f

Hyperledger Cactus Plugins/Connectors Used

All of them.

Additional context

There's also an open issue for changing the GHA ci.yml file so that it runs the tools/ci.sh instead of directly invoking the npm scripts. This is relevant here because had we already implemented that change, this bug would've been caught much earlier on.

cc: @opentaps @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo
@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience Fabric good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Mar 16, 2021
@petermetz petermetz self-assigned this Mar 16, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 16, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
40b6fa1 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Mar 16, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Mar 23, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
5db3cb5 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 25, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
6e485ab 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 25, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
cc156d8 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 25, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
3ea4772 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Mar 25, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Mar 26, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
51b9841 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 26, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
fd130b6 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
kikoncuo pushed a commit that referenced this issue Mar 29, 2021
@petermetz @kikoncuo
fix(tools): prod build fail due to missing dependency ngo #673
c93cd30 
The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes #673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue Apr 8, 2021
@petermetz
fix(tools): prod build fail due to missing dependency ngo hyperledger…
a9b0731 
…#673

The dependency was removed accidentally during a refactor
where we deprecated the chain code compiler component
in its current form (ngo is a depenency of that). Later on
they are both scheduled to depart from the codebase (ngo
and the chain code compiler) but that will be part of a larger
refactor so for now I just added the missing dependency back
to ensure that the `./tools/ci.sh` script doesn't crash when
it runs the production build (the one that bundles with
webpack and minifies it as well)

Fixes hyperledger#673

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience Fabric good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tools): prod build fail due to missing dependency ngo #673 petermetz/cacti
1 participant
@petermetz