Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-fabric): fix module requires Go 1.17 #914

Closed
petermetz opened this issue May 4, 2021 · 0 comments · Fixed by #915
Closed

test(connector-fabric): fix module requires Go 1.17 #914

petermetz opened this issue May 4, 2021 · 0 comments · Fixed by #915
Assignees
@petermetz
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Fabric
Milestone
v0.6.0

Comments

@petermetz
Copy link
Member

Describe the bug

The hello world contract we deploy for the 1.4.x tests via go sources does not have it's dependencies pinned in the tests so the auto-upgrade finally broke the test:

'go: finding golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> '# golang.org/x/net/http2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> '../../pkg/mod/golang.org/x/net@v0.0.0-20210504132125-bbd867fde50d/http2/transport.go:598:14: undefined: tls.Dialer\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> 'note: module requires Go 1.17',

To Reproduce

Run the tests.

Expected behavior

Tests pass.

Logs/Stack traces

om:7051 --env CORE_PEER_MSPCONFIGPATH=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/peerOrganizations/org1.example.com/users/Admin@org1.example.com/msp --env CORE_PEER_TLS_ROOTCERT_FILE=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/peerOrganizations/org1.example.com/peers/peer0.org1.example.com/tls/ca.crt --env ORDERER_TLS_ROOTCERT_FILE=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/ordererOrganizations/example.com/orderers/orderer.example.com/msp/tlscacerts/tlsca.example.com-cert.pem --env GO111MODULE=on --workdir=/opt/gopath/src/hello-world cli  go build
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> [2021-05-04T16:24:20.590Z] DEBUG (PluginLedgerConnectorFabric): go build CMD Response: {
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   code: 2,
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   signal: null,
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   stdout: 'debug1: permanently_set_uid: 0/0\r\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'Environment:\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  USER=root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  LOGNAME=root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  HOME=/root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  PATH=/bin:/usr/bin:/sbin:/usr/sbin\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  MAIL=/var/mail/root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SHELL=/bin/ash\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  TERM=vt100\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SSH_CLIENT=172.17.0.1 57648 22\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SSH_CONNECTION=172.17.0.1 57648 172.17.0.2 22\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SSH_TTY=/dev/pts/1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding google.golang.org/protobuf v1.26.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/fsnotify/fsnotify v1.4.9\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/hashicorp/hcl v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/magiconair/properties v1.8.1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/pelletier/go-toml v1.2.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/jwalterweatherman v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/cast v1.3.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/afero v1.1.2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/subosito/gotenv v1.2.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding go.uber.org/atomic v1.6.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding go.uber.org/multierr v1.5.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding gopkg.in/ini.v1 v1.51.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/pflag v1.0.3\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding golang.org/x/sys v0.0.0-20210423082822-04245dca01da\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/docker/docker v20.10.3-0.20210216175712-646072ed6524+incompatible\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding golang.org/x/text v0.3.6\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/docker/go-units v0.4.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/opencontainers/image-spec v1.0.1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/containerd/containerd v1.4.3\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/docker/go-connections v0.4.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/sirupsen/logrus v1.7.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/moby/sys/mount v0.2.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/containerd/continuity v0.0.0-20210208174643-50096c924a4e\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/morikuni/aec v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/moby/term v0.0.0-20201216013528-df9cb8a40635\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/opencontainers/runc v0.1.1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/gogo/protobuf v1.3.2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/opencontainers/go-digest v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/moby/sys/mountinfo v0.4.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '# golang.org/x/net/http2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '../../pkg/mod/golang.org/x/net@v0.0.0-20210504132125-bbd867fde50d/http2/transport.go:598:14: undefined: tls.Dialer\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'note: module requires Go 1.17',
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   stderr: ''

Cloud provider or hardware configuration:

Dev machine

Operating system name, version, build:

Use this command: printf "$(uname -srm)\n$(cat /etc/os-release)\n"

For example

$ $ printf "$(uname -srm)\n$(cat /etc/os-release)\n"
Linux 5.8.0-50-generic x86_64
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main @ today

Hyperledger Cactus Plugins/Connectors Used

Fabric

Additional context

N/A

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy
@petermetz petermetz added bug Something isn't working Fabric dependencies Pull requests that update a dependency file labels May 4, 2021
petermetz added a commit to petermetz/cacti that referenced this issue May 4, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
8918518 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 4, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
4234944 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue May 4, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue May 4, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
10487a1 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added this to the v0.5.0 milestone May 4, 2021
petermetz added a commit to petermetz/cacti that referenced this issue May 6, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
ca14664 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
AzaharaC pushed a commit to kikoncuo/cactus that referenced this issue May 6, 2021
@petermetz @AzaharaC
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
2e468fa 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
AzaharaC pushed a commit to kikoncuo/cactus that referenced this issue May 6, 2021
@petermetz @AzaharaC
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
7625018 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz self-assigned this May 7, 2021
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 14, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
3c4b2fc 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 14, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
fee24ee 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz modified the milestones: v0.5.0, v0.6.0 May 19, 2021
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 20, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
a85292c 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 20, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
de0f824 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 20, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
fbabe34 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 20, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
b08e0db 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 21, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
59ef093 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 21, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
10eae46 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 21, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
6af5dc3 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 21, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
edc1760 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 21, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
bf847dd 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue May 21, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
b8ef6af 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 25, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
1e63ee8 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 25, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
5f73655 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 25, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
434e7d8 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 25, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
03a6783 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 27, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
2a9dd27 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 27, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
8f6b98a 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 28, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
119e1ff 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue May 28, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
07099fd 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue May 28, 2021
@petermetz
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
d28ed6e 
This was initially a candidate for resolving the issue of #914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue May 28, 2021
@petermetz
test(connector-fabric): fix module requires Go 1.17 #914
e8708a6 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes #914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@petermetz @RafaelAPB
feat(tools): upgrade go to 1.16.3 in Fabric 1.4.x AIO image
9090d44 
This was initially a candidate for resolving the issue of hyperledger#914 but
later that idea turned out to not work.
At the end of the day we always thrive to work with the latest and
greatest of all of our dependencies CVEs permitting so the upgrade
can stay in as a valid change.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@petermetz @RafaelAPB
test(connector-fabric): fix module requires Go 1.17 hyperledger#914
ab69715 
Primary change:
------------------

Pinned the buggy dependency to yesterday's version
(the bug was introduced in this morning's build).

This prevents today's version from being used and
fixes the problem.

Secondary change:
--------------------

Upgraded the container image that's being used for the test to
the one that has the fabric images pre-cached.
This leads to faster test execution and lower probability
of developers getting hit by the dreaded DockerHub rate limiting issue.

Fixes hyperledger#914

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working dependencies Pull requests that update a dependency file Fabric
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

test(connector-fabric): fix module requires Go 1.17 #914 petermetz/cacti
1 participant
@petermetz