Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(connector-iroha): add Iroha menu item in the ledger support matrix #1284

Merged
merged 1 commit into from Sep 27, 2021

Conversation

hanxu12
Copy link
Contributor

@hanxu12 hanxu12 commented Aug 31, 2021

Depends on #1290

@hanxu12 hanxu12 changed the title fix(doc): fix iroha doc url and version docs(connector-iroha): add test case link to support matrix Aug 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #1284 (3fec59b) into main (466db28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1284   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files         301      301           
  Lines       10949    10949           
  Branches     1348     1348           
=======================================
  Hits         7515     7515           
  Misses       2733     2733           
  Partials      701      701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466db28...3fec59b. Read the comment docs.

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hxlaf LGTM, but will leave it in "Requesting changes" state until we can verify that the links works. Please make sure to double check it once the dependent PR has been merged (which will then lead to us having a tag of v0.9.0

@petermetz petermetz requested review from takeutak and removed request for jonathan-m-hamilton September 1, 2021 00:04
@petermetz petermetz added documentation Improvements or additions to documentation Iroha Bugs/features related to the Iroha ledger connector plugin labels Sep 1, 2021
@petermetz petermetz added this to the v0.10.0 milestone Sep 1, 2021
@github-actions github-actions bot removed the dependent label Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@hanxu12 hanxu12 closed this Sep 10, 2021
@hanxu12 hanxu12 changed the title docs(connector-iroha): add test case link to support matrix docs(connector-iroha): add Iroha menu item in the ledger support matrix Sep 25, 2021
@hanxu12 hanxu12 reopened this Sep 25, 2021
@hanxu12 hanxu12 closed this Sep 25, 2021
@hanxu12 hanxu12 reopened this Sep 25, 2021
@petermetz petermetz merged commit a6ebff5 into hyperledger:main Sep 27, 2021
@petermetz petermetz deleted the fix_doc branch September 27, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Iroha Bugs/features related to the Iroha ledger connector plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants