Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validator): Iroha validator using python #1327

Merged
merged 3 commits into from Sep 25, 2021

Conversation

tkyonezu
Copy link
Contributor

@tkyonezu tkyonezu commented Sep 14, 2021

Hyperledger Iroha Validator

@takeutak takeutak changed the title Iroha validator draft feat(validator): Iroha validator draft Sep 14, 2021
@takeutak takeutak changed the title feat(validator): Iroha validator draft feat(validator): Iroha validator using python Sep 14, 2021
@takeutak
Copy link
Member

Thanks for contributing your code!
As your proposal, there is a quite need for socketio-typed validators to Iroha developed by Python because it is necessary to expand the communication type and the diversity of development languages in order to increase the kinds of developers.

I created a new issue #1328 and I'm sure that your PR resolves this issue.
LGTM

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkyonezu Please rebase and squash the commits

Signed-off-by: Takeshi Yonezu <tkyonezu@gmail.com>
@takeutak
Copy link
Member

@petermetz
It seems that @tkyonezu has finished rebase and squash.
Would you mind if you review this PR again?

@petermetz
Copy link
Member

@petermetz
It seems that @tkyonezu has finished rebase and squash.
Would you mind if you review this PR again?

@takeutak It still has multiple commits from what I can tell.

@takeutak
Copy link
Member

takeutak commented Sep 22, 2021

@petermetz Thanks for your response. As you said, I'm afraid that I misunderstood the problem. So I will contact @tkyonezu again.
According to the commits https://github.com/hyperledger/cactus/pull/1327/commits, there are some unrelated commits as the following, so I think it is good to git rebase to remove these commits on the PR. Is this all right for you?

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #1327 (86b4a92) into main (90e4dd1) will not change coverage.
The diff coverage is n/a.

❗ Current head 86b4a92 differs from pull request most recent head 071b9af. Consider uploading reports for the commit 071b9af to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files         301      301           
  Lines       10949    10949           
  Branches     1348     1348           
=======================================
  Hits         7515     7515           
  Misses       2733     2733           
  Partials      701      701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e4dd1...071b9af. Read the comment docs.

@takeutak
Copy link
Member

@petermetz
@tkyonezu executed git squash and there are one commit as the following:
https://github.com/hyperledger/cactus/pull/1327/commits

Would you mind approving this PR?

@petermetz petermetz merged commit 466db28 into hyperledger:main Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants