New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validator): Iroha validator using python #1327
Conversation
Thanks for contributing your code! I created a new issue #1328 and I'm sure that your PR resolves this issue. |
292b360
to
a0fd1b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkyonezu Please rebase and squash the commits
Signed-off-by: Takeshi Yonezu <tkyonezu@gmail.com>
a0fd1b9
to
958bc7f
Compare
@petermetz |
@takeutak It still has multiple commits from what I can tell. |
@petermetz Thanks for your response. As you said, I'm afraid that I misunderstood the problem. So I will contact @tkyonezu again. |
7926f9c
to
3d36d90
Compare
Codecov Report
@@ Coverage Diff @@
## main #1327 +/- ##
=======================================
Coverage 68.63% 68.63%
=======================================
Files 301 301
Lines 10949 10949
Branches 1348 1348
=======================================
Hits 7515 7515
Misses 2733 2733
Partials 701 701 Continue to review full report at Codecov.
|
@petermetz Would you mind approving this PR? |
Hyperledger Iroha Validator