feat(corda): add Corda ledger support #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
force-pushed
the
feat/ledger-connector-corda-v2-143
branch
from
7021c6d
to
2d1b5af
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
takeutak
previously approved these changes
Mar 2, 2021
petermetz
force-pushed
the
feat/ledger-connector-corda-v2-143
branch
2 times, most recently
from
a756c34
to
860254c
Compare
petermetz
dismissed stale reviews from takeutak and jonathan-m-hamilton
via
b73a6c5
petermetz
force-pushed
the
feat/ledger-connector-corda-v2-143
branch
4 times, most recently
from
4fa974a
to
ac0d32a
Compare
Primary Changes =============== 1. Corda all-in-one image Note: In this state of it it runs the full sample with all the nodes and web servers which ends up using 11GB of RAM so we will have to thin this down eventually once the Corda connector is otherwise passing the tests with this container. Once we are at that point we can start removing parts of the AIO container to reduce RAM usage and verify that the tests are still passing without issues or not. 2. Corda ledger connector server as a JVM app (uses the "kotlin-spring" generator template from OpenAPI) The only file that is non-generated in that folder is the service implementation called ApiPluginLedgerConnectorCordaServiceImpl.kt TODO: make sure the generated folder can be cleaned and regenerated without having to manually re-add the implementation file mentioned above. 3. The Typescript interfaces necessary for the NodeJS API server to be able to communicate with the JVM app in a transparent manner where higher level plugins can talk to Corda through the connector in Typescript without realizing that they are actually sending HTTP requests over the network to the JVM app. 4. Home-grown, JSON-embedded DSL is used to define the flow params. 5. Lots of to-dos still, but there are end to end tests passing and everything is working with containers. 6. Jar deployment is only partially supported for now: if the jar is already present on the node, then calling the jar deploy endpoint on the connector will make sure to add that jar to the classpath of the connector as well. If however the jar is not deployed on the corda node itself then it will no work just yet because the SSH connection is not yet implemented in the corda connector. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
feat/ledger-connector-corda-v2-143
branch
from
4dde8b6
to
c8dc500
Compare
takeutak
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #607
Fixes #547
Fixes #143
Primary Changes
Runs the notary and 3 participants for the obligation advanced
kotlin sample.
(uses the "kotlin-spring" generator template from OpenAPI)
The only file that is non-generated in that folder is the
service implementation called ApiPluginLedgerConnectorCordaServiceImpl.kt
TODO: make sure the generated folder can be cleaned and regenerated
without having to manually re-add the implementation file mentioned
above.
The Typescript interfaces necessary for the NodeJS API server to
be able to communicate with the JVM app in a transparent manner where
higher level plugins can talk to Corda through the connector in Typescript
without realizing that they are actually sending HTTP requests over the
network to the JVM app.
Home-grown, JSON-embedded DSL is used to define the flow params.
Lots of to-dos still, but there are end to end tests passing
and everything is working with containers.
Jar deployment is only partially supported for now: if the jar
is already present on the node, then calling the jar deploy endpoint
on the connector will make sure to add that jar to the classpath of
the connector as well. If however the jar is not deployed on the corda
node itself then it will no work just yet because the SSH connection
is not yet implemented in the corda connector.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com