Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting of the Go/Java/Javascript code #262

Open
davidkel opened this issue Apr 16, 2024 · 0 comments
Open

Add linting of the Go/Java/Javascript code #262

davidkel opened this issue Apr 16, 2024 · 0 comments
Labels
build enhancement New feature or request

Comments

@davidkel
Copy link
Contributor

We should add this ability to help contributors/maintainers to delivery quality code. Some thoughts on this feature

  1. It needs to be added to the build to verify PRs
  2. It should use node to run the linters as node is a pre-requisite for caliper so would be installed. Reason for this is that node is platform agnostic so is useable in native Windows
  3. we should match the linter rules used in caliper for node and so use the same lint engine
  4. I don't think we need to run gofmt as all good go ides will do this for you. There is a go linter golangci-lint we can use
  5. for java we could use checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant