-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang features implementation #15
Comments
@jkneubuh FYI |
Thanks @SamYuan1990 those look like a good set of features for addition to the library. A couple of questions / comments:
|
thanks for your comments for for add new org to channel, in my point of view, it can been treated as update channel setting? |
@SamYuan1990 Have you looked at the fabric-config library? |
thanks @denyeart , I will take a look at and feedback. |
@denyeart, @jkneubuh , @davidkhala ,
so, 1st of all, I would like to follow TDD method to implement all features. because of for operator(labs project) point of view, a sdk project it has fabric dependency there https://github.com/hyperledger-labs/fabric-operator/blob/main/go.mod#L11 and for decouple peer cli and peer server and if we plan to merge back to fabric repo(if needed) then the implementation should be keep. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @SamYuan1990 and @bestbeforetoday, I managed to develop the query committed function (#39) and would like to start contributing to the project. It was only possible with the refactor in PR #87 so I'll wait for the approval and merge so I can get the modifications from |
Channel configuration needs to have the capability to set anchor peers, otherwise service discovery does not work. |
Contributions would be very welcome! We probably need to have a pass through the work still outstanding and make sure everything is raised as separate issues so we can more easily assign who is actually working on them. I will make a start on that from my perspective as soon as I can. |
@samuelvenzi PR #87 is now merged so you can base changes in top of that. |
Thanks, @bestbeforetoday. It's on #88 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @SamYuan1990. Is this issue still relevant? If not, what are some pending features that I could take a look? |
@SamYuan1990 any pointers on how I can help? 😄 |
I think |
thanks @davidkhala, I just received from sick in recent , @samuelvenzi yes, you can start with peer discovery. :-) |
@SamYuan1990 Considering that most of sdk users have now migrated to peer gateway, I would like to label item |
LGTM, and I am supposing we are good with this ticket and going to close it. |
Channel
Chaincode
tools(should move to fabric-cli repo)
The text was updated successfully, but these errors were encountered: