This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
Add Deprecation Notice #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindluni
reviewed
Jul 21, 2020
README.md
Outdated
Comment on lines
11
to
13
| Baseimage is essentially retired already. There are several months left on the Fabric 1.4 LTS and then we will archive the repo. | ||
|
|
||
| None of those images in Baseimage are used in Fabric release-2.x anymore |
There was a problem hiding this comment.
Thanks David for doing this, but can we change it to something like this:
The Fabric-Baseimage repository and the images built from this repository are deprecated. Critical bugs will continue to be patched through the Fabric 1.4.x LTS lifecycle. The images affected by this deprecation are:
- hyperledger/fabric-baseimage (with a version < 1.0.0)
- hyperledger/fabric-baseos (with a version < 1.0.0)
- hyperledger/fabric-couchdb (all versions)
- hyperledger/fabric-zookeeper (all versions)
- hyperledger/fabric-kafka (all versions)
Users should migrate to open source versions of these images.
There was a problem hiding this comment.
Can we also put the deprecation notice as the first item in the README
lindluni
suggested changes
Jul 21, 2020
README.md
Outdated
Comment on lines
11
to
13
| Baseimage is essentially retired already. There are several months left on the Fabric 1.4 LTS and then we will archive the repo. | ||
|
|
||
| None of those images in Baseimage are used in Fabric release-2.x anymore |
There was a problem hiding this comment.
Can we also put the deprecation notice as the first item in the README
Per explanation from Bret Logan Signed-off-by: davidliu <david-khala@hotmail.com>
lindluni
approved these changes
Jul 22, 2020
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per explanation from Bret Logan
Signed-off-by: davidliu david-khala@hotmail.com