This repository has been archived by the owner on Dec 2, 2021. It is now read-only.
FAB-16697 remove linters #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go lint is not run. Remove go lint. go fmt and goimports do the same thing. goimports is more powerful due to import reordering, so rely only on goimports. Remove go fmt. The build cache is not the build cache we use for building a binary, so we end up building everything multiple times instead of using the cache. Remove the cache definition. go vet is intelligent and ignores the vendor directory on it's own. Take it out of the loop and invoke it once at the top level. Change-Id: Ieb057298f6ecd83b67607de29c24572a4c35018a Signed-off-by: Morgan Bauer <mbauer@us.ibm.com>
MHBauer
requested review from
christo4ferris,
guoger,
mastersingh24 and
muralisrini
as code owners
|
Agree with removing gofmt, since goimports does the same thing. Instead of removing golint, should we add it to the list? My understanding it is about code style and is different from go vet. Though our code probably does not pass golint in its current state. |
swetharepakula
approved these changes
Sep 27, 2019
|
I have mixed feelings on golint. Most of the work required right now is for "XYZ must have godoc" which I am not going to complete as part of this. We should make a JIRA. FYI, golint is also not turned on in fabric core repo. |
|
as an automated process, that branch update thing is terrible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go lint is not run. Remove go lint.
go fmt and goimports do the same thing. goimports is more powerful due
to import reordering, so rely only on goimports. Remove go fmt.
The build cache is not the build cache we use for building a binary,
so we end up building everything multiple times instead of using the
cache. Remove the cache definition.
go vet is intelligent and ignores the vendor directory on it's
own. Take it out of the loop and invoke it once at the top level.
Change-Id: Ieb057298f6ecd83b67607de29c24572a4c35018a
Signed-off-by: Morgan Bauer mbauer@us.ibm.com