This repository has been archived by the owner on Dec 2, 2021. It is now read-only.
Rename binary to fab-3 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the change, there will be an error: build output "fab3" already exists and is a directory.
|
Thank you for your contribution! Please use gerrit for the changes, see documentation here |
|
Hi Andrew, We have created an issue that you can reference in your commit: https://jira.hyperledger.org/browse/FAB-13947. |
|
Thank you for your contribution! Please use gerrit for the changes, see documentation here |
MHBauer
referenced
this pull request
in MHBauer/fabric-chaincode-evm
Feb 22, 2019
Also fixed a couple of errors found by go vet Patch-set #2: added a couple of missing changes Change-Id: Ibf70f9a408f68bbd1b1d616098fb777a8efa1fd7 Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change, there will be an error: build output "fab3" already exists and is a directory.
Another option is to change the folder name ./fab3 to something else. What is preferred?