This repository has been archived by the owner on Dec 2, 2021. It is now read-only.
FABCE-145 update README for 0.4.0 release #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MHBauer
commented
Dec 19, 2019
•
MHBauer
commented
- doc change
- Added the associated JIRA ticket number in the commit message title
- Link to the JIRA Ticket: https://jira.hyperledger.org/browse/FABCE-145
MHBauer
requested review from
christo4ferris,
guoger,
mastersingh24,
muralisrini and
swetharepakula
as code owners
swetharepakula
suggested changes
Dec 19, 2019
README.md
Outdated
| @@ -189,13 +190,12 @@ include the JIRA number associated with your JIRA work item in the commit | |||
| message title. | |||
|
|
|||
| To report a new issue, open a ticket in the Hyperledger Fabric [JIRA](https://jira.hyperledger.org/projects/FAB/issues) | |||
There was a problem hiding this comment.
Suggested change
| To report a new issue, open a ticket in the Hyperledger Fabric [JIRA](https://jira.hyperledger.org/projects/FAB/issues) | |
| To report a new issue, open a ticket in the Hyperledger Fabric [JIRA](https://jira.hyperledger.org/projects/FABCE/issues) |
MHBauer
force-pushed
the
master
branch
2 times, most recently
from
8df734b
to
361ed2d
Compare
MHBauer
changed the title
fabric-chaincode-evm project! Please look at our [Contributions Docs](../README.md#Contributions) and make sure you have done the following before submitting:
|
not 100% sure if the commit thing is helpful. but it is very clear to see the change. |
|
@swetharepakula should I add the 0.4.0 release notes to this PR or a follow on? |
|
add the release notes and changelog to a follow on pr |
swetharepakula
suggested changes
Dec 21, 2019
Switched from gerrit to github for checkout. Modules does not require GOPATH for building. go 1.11 and up required. We now have FABCE JIRA project. Dep no longer used. Signed-off-by: Morgan Bauer <mbauer@us.ibm.com>
|
weird, thought I had already made that change, but it got lost somewhere. |
swetharepakula
approved these changes
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.