Update to Fabric v2.1.1 #369
Conversation
Signed-off-by: Michael Steiner <michael.steiner@intel.com>
There was a problem hiding this comment.
Seems to work fine in my docker setting.
Interestingly, I cannot reproduce the go vet issue you are mentioning. What I did: I just checkout out your PR; started a fresh docker container with cd utils/docker; make run,
inside the container I checkout the fabric v2.2.1 tag and finally hit make inside docker. All smooth.
Sorry if i was not clear: the |
What this PR does / why we need it:
Subject says it (mostly) all. Upgrade to latest Fabric release, now also upgrading go modules (which were still on v2.0.1 before ...).
See release notes for more info on v2.1.1 (most noticeable for us was that external builder stopped handling some symlinks it has handled in past ...)
Note: for go modules, just updating the fabric dependency in go.mod didn't work (everything built, tests run but go vet failed). To make it work i did a
go get -u .$pkgwithpkgfor all github.com/hyperledger/fabric*' packages found ingo.mod.. and then did ago mod tidyat end. Hope that was the correct process; at least it seemed to work ;-)Which issue(s) this PR fixes:
Related to issue #370
Special notes for your reviewer:
To test, you will have to move the tag on fabric from v2.1.0 to v2.1.1.
Does this PR introduce a user-facing changes and/or breaks backward compatability?: