-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test-network-k8s #840
Comments
I would like to discuss this topic. I would appreciate if test-network-k8s could remain in fabric-samples. Could you tell us why you are considering removing it and when you plan to do so? |
Ok, if there are fans of test-network-k8s let's keep it around. |
@denyeart I am interested in troubleshooting, fixing, and maintaining it going forward. I just checked the cause of this CI failure and it seems that k8s builder executable cannot be executed for some reason. Since Japan is on vacation this week, I will make and submit patches to fabric-samples and hyperledger-labs/fabric-builder-k8s to resolve this issue in the next week or so. |
Thanks @satota2 ! |
@denyeart I submitted a patch to resolve the distribution miss match between k8s builder image and Fabric peer image to fabric-builder-k8s repo. I ran test-network-k8s in my local environment with a Docker image based on the above patch and confirmed that it runs successfully. So, the above patch is merged and the image based on it is published, test-network-k8s will be ready for Fabric v2.5 support. If the merge of this patch takes a long period of time or is unacceptable, I will try to fix how to get k8s-builder binaries on the test-network-k8s side. |
@denyeart Hi, yes, still planning to keep fabric-builder-k8s maintained. I was already planning to update it to Fabric 2.5 - hyperledger-labs/fabric-builder-k8s#90 - which it looks like @satota2 has submitted a PR for 🥇 |
I've released fabric-builder-k8s v0.11.0 which should hopefully help- let me know if there are any problems. |
@denyeart Thanks! Please let me know if there is anything I can do to help maintain test-network-k8s😊 |
Remove test-network-k8s in favor of fabric-operator and asset-transfer workshop.
The text was updated successfully, but these errors were encountered: