[FAB-8946] Dynamic selection caching bug

The dynamic selection PG resolver cache should
be a cache of lazy references but instead the
value is being retrieved from the reference and
the value is being cached.

Change-Id: I799dccd5ded77362e60ddc9569dbfabf0414ab8e
Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>

pkg/client/common/selection/dynamicselection/dynamicselection.go

@@ -133,7 +133,7 @@ func newSelectionService(channelID string, lbp pgresolver.LoadBalancePolicy, ccP
 					return service.createPGResolver(key.(*resolverKey))
 				},
 				lazyref.WithAbsoluteExpiration(cacheTimeout),
-			).Get()
+			), nil
 		},
 	)
 
@@ -164,7 +164,12 @@ func (s *selectionService) getPeerGroupResolver(chaincodeIDs []string) (pgresolv
 	if err != nil {
 		return nil, err
 	}
-	return value.(pgresolver.PeerGroupResolver), nil
+	lazyRef := value.(*lazyref.Reference)
+	resolver, err := lazyRef.Get()
+	if err != nil {
+		return nil, err
+	}
+	return resolver.(pgresolver.PeerGroupResolver), nil
 }
 
 func (s *selectionService) createPGResolver(key *resolverKey) (pgresolver.PeerGroupResolver, error) {