[BUILD] Move golang linter into a script

We can reuse the array definition to perform both the go-vet
and go-import operations.  This also sets the stage for
running the linter within a docker instance later in the
series.

Change-Id: I5fcda6c441cfef49837b855a2d6bb2cc3d300847
Signed-off-by: Greg Haskins <gregory.haskins@gmail.com>

Makefile

@@ -104,15 +104,7 @@ behave: behave-deps
 
 linter: gotools
 	@echo "LINT: Running code checks.."
-	@echo "Running go vet"
-	go vet ./core/...
-	go vet ./events/...
-	go vet ./examples/...
-	go vet ./peer/...
-	go vet ./protos/...
-	go vet ./orderer/...
-	@echo "Running goimports"
-	@./scripts/goimports.sh
+	@./scripts/golinter.sh
 
 # We (re)build protoc-gen-go from within docker context so that
 # we may later inject the binary into a different docker environment

scripts/golinter.sh

@@ -0,0 +1,18 @@
+#!/bin/bash
+
+set -e
+
+declare -a arr=("./core" "./events" "./examples" "./peer" "./protos" "./orderer")
+
+for i in "${arr[@]}"
+do
+    echo "Checking $i"
+    go vet $i/...
+    OUTPUT="$(goimports -srcdir $GOPATH/src/github.com/hyperledger/fabric -l $i)"
+    if [[ $OUTPUT ]]; then
+	echo "The following files contain goimports errors"
+	echo $OUTPUT
+	echo "The goimports command must be run for these files"
+	exit 1
+    fi
+done