Skip to content

Commit

Permalink
FAB-9751 Remove flaky logging concurrency test
Browse files Browse the repository at this point in the history
The logging infrastructure is set to be replaced soon.  There is a test
which attempted to verify that the concurrency hacks were left in place
in the vendored package.  However, this vendored package has been
updated and the hacks removed, so this test is actually a false-negative
when it passes.  Removing it.

Change-Id: I6f96574ca03f0938a15e1a4a3adeca9910c42a9b
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>
  • Loading branch information
Jason Yellick committed May 1, 2018
1 parent d9a207c commit 7cfa7a0
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions common/util/utils_test.go
Expand Up @@ -24,7 +24,6 @@ import (
"testing"
"time"

"github.com/op/go-logging"
"github.com/stretchr/testify/assert"
)

Expand Down Expand Up @@ -153,24 +152,6 @@ func TestArrayToChaincodeArgs(t *testing.T) {
}
}

// This test checks go-logging is thread safe with regard to
// concurrent SetLevel invocation and log invocations.
// Fails without the concurrency fix (adding RWLock to level.go)
// In case the go-logging will be overwritten and its concurrency fix
// will be regressed, this test should fail.
func TestConcurrencyNotFail(t *testing.T) {
logger := logging.MustGetLogger("test")
go func() {
for i := 0; i < 100; i++ {
logging.SetLevel(logging.Level(logging.DEBUG), "test")
}
}()

for i := 0; i < 100; i++ {
logger.Info("")
}
}

func TestMetadataSignatureBytesNormal(t *testing.T) {
first := []byte("first")
second := []byte("second")
Expand Down

0 comments on commit 7cfa7a0

Please sign in to comment.