Skip to content

Commit

Permalink
[FAB-13303] increase reconciliation test coverage
Browse files Browse the repository at this point in the history
Change-Id: Ifedef26a3abc30a5dfcdea597b09df8746593999
Signed-off-by: Artem Barger <bartem@il.ibm.com>
  • Loading branch information
C0rWin committed Dec 17, 2018
1 parent 44325b4 commit cfdb44d
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions gossip/privdata/reconcile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -424,3 +424,31 @@ func TestReconciliationFailedToCommit(t *testing.T) {
assert.Error(t, err)
assert.Contains(t, err.Error(), "failed to commit")
}

func TestFailuresWhileReconcilingMissingPvtData(t *testing.T) {
committer := &mocks.Committer{}
fetcher := &mocks.ReconciliationFetcher{}
committer.On("GetMissingPvtDataTracker").Return(nil, errors.New("failed to obtain missing pvt data tracker"))

r := NewReconciler(committer, fetcher, &ReconcilerConfig{sleepInterval: time.Millisecond * 100, batchSize: 1, IsEnabled: true})
err := r.reconcile()
assert.Error(t, err)
assert.Contains(t, "failed to obtain missing pvt data tracker", err.Error())

committer.Mock = mock.Mock{}
committer.On("GetMissingPvtDataTracker").Return(nil, nil)
r = NewReconciler(committer, fetcher, &ReconcilerConfig{sleepInterval: time.Millisecond * 100, batchSize: 1, IsEnabled: true})
err = r.reconcile()
assert.Error(t, err)
assert.Contains(t, "got nil as MissingPvtDataTracker, exiting...", err.Error())

missingPvtDataTracker := &mocks.MissingPvtDataTracker{}
missingPvtDataTracker.On("GetMissingPvtDataInfoForMostRecentBlocks", mock.Anything).Return(nil, errors.New("failed get missing pvt data for recent blocks"))

committer.Mock = mock.Mock{}
committer.On("GetMissingPvtDataTracker").Return(missingPvtDataTracker, nil)
r = NewReconciler(committer, fetcher, &ReconcilerConfig{sleepInterval: time.Millisecond * 100, batchSize: 1, IsEnabled: true})
err = r.reconcile()
assert.Error(t, err)
assert.Contains(t, "failed get missing pvt data for recent blocks", err.Error())
}

0 comments on commit cfdb44d

Please sign in to comment.