Skip to content

Commit

Permalink
[FAB-2605] Fix hard-coded start for deliver_stdout
Browse files Browse the repository at this point in the history
https://jira.hyperledger.org/browse/FAB-2605

The SeekInfo message broadcasted by the deliver_stdout client had its
start field hard-coded to the `SeekOldest` message. This isn't really a
problem so far since we use the client to deliver from the oldest block
available anyway, but the code is wrong, and when we extend the client
(as we will do in a subsequent changeset), leaving this unfixed will
come back to haunt us.

Change-Id: Id2b06be1a632e42104bd696f6c67f23da27b5a03
Signed-off-by: Kostas Christidis <kostas@christidis.io>
  • Loading branch information
kchristidis committed Mar 2, 2017
1 parent 356ce27 commit d4fa505
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion orderer/sample_clients/deliver_stdout/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func seekHelper(chainID string, start *ab.SeekPosition) *cb.Envelope {
},

Data: utils.MarshalOrPanic(&ab.SeekInfo{
Start: &ab.SeekPosition{Type: &ab.SeekPosition_Oldest{Oldest: &ab.SeekOldest{}}},
Start: start,
Stop: &ab.SeekPosition{Type: &ab.SeekPosition_Specified{Specified: &ab.SeekSpecified{Number: math.MaxUint64}}},
Behavior: ab.SeekInfo_BLOCK_UNTIL_READY,
}),
Expand Down

0 comments on commit d4fa505

Please sign in to comment.