History entries does not reflect the real time the an event occured

[Chengxuan]

The timestamp of each event is calculated on AddSubStatus function:

firefly-transaction-manager/internal/persistence/postgres/txhistory.go

Line 100 in 2175fff

now := fftypes.Now()

However, the invocation of AddSubStatus function reflects when an event was recorded but not when it occurred.

So the interface will need to change to allow a timestamp to be passed in

[Philip-21]

Hey @Chengxuan will it be best implementing the Now() in the firefly-common library to explicitly check for specific timestamps

func Now(t ...time.Time) *FFTime {
	var currentTime time.Time
	if len(t) > 0 {
                //extracts current time and coverts to UTC
		currentTime = t[0].UTC()
	} else {
		currentTime = time.Now().UTC()
	}
	tt := FFTime(currentTime)
	return &tt
}

Currently this is the Now() in the firefly-common library

func Now() *FFTime {
	t := FFTime(time.Now().UTC())
	return &t
}

[Chengxuan]

@Philip-21 I feel Now should always return the time that Now function is executed instead of a time that is not now.

To address this issue, we need to move away from the now time at this layer as it's already too late, so this layer would need to take in a timestamp.

e.g.

func (p *sqlPersistence) AddSubStatusAction(ctx context.Context, txID string, subStatus apitypes.TxSubStatus, action apitypes.TxAction, info *fftypes.JSONAny, errInfo *fftypes.JSONAny)

becomes

func (p *sqlPersistence) AddSubStatusAction(ctx context.Context, txID string, subStatus apitypes.TxSubStatus, action apitypes.TxAction, info *fftypes.JSONAny, errInfo *fftypes.JSONAny, t *fftypes.FFTime)

[Philip-21]

alright