Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Fix Libvcx C Error Message Segfault #1293

Conversation

hadleym
Copy link
Contributor

@hadleym hadleym commented Nov 16, 2018

Fixes the current libvcx vcx_error_c_message api call. In the current version of vcx_error_c_message, the memory returned via pointer is dropped at the end of the api call, causing undefined behavior when the wrappers dereference the returned pointer.

Mark Hadley added 6 commits November 15, 2018 09:49
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
@hadleym
Copy link
Contributor Author

hadleym commented Nov 16, 2018

@glowkey
Please review.

Copy link
Contributor

@Artemkaaas Artemkaaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't compile on jenkins

#[repr(transparent)]
   | ^^^^^^^^^^^^^^^^^^^^

error[E0658]: the `#[repr(transparent)]` attribute is experimental (see issue #43036)

update rust version.

@jovfer
Copy link
Contributor

jovfer commented Nov 19, 2018

@hadleym please fix Java wrapper too

@jovfer
Copy link
Contributor

jovfer commented Nov 19, 2018

double-check Artem's suggestion on Jenkins: yes, with incremented rust version this PR can pass build stage on Jenkins for VCX (jovfer@95b7d2a).

@hadleym
Copy link
Contributor Author

hadleym commented Nov 19, 2018

@jovfer
I will fix the Java wrapper as well as the rust version as suggested by @Artemkaaas

Copy link

@glowkey glowkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold off on merging this PR until I have had a chance to review it.

@hadleym hadleym closed this Nov 19, 2018
@hadleym
Copy link
Contributor Author

hadleym commented Nov 19, 2018

@glowkey has found the correct reason for the python segfaults regarding vcx_error_c_message, and will implement a fix in his future PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants