Fix Libvcx C Error Message Segfault #1293
Fix Libvcx C Error Message Segfault #1293
Conversation
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
Signed-off-by: Mark Hadley <mark.hadley@evernym.com>
@glowkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't compile on jenkins
#[repr(transparent)]
| ^^^^^^^^^^^^^^^^^^^^
error[E0658]: the `#[repr(transparent)]` attribute is experimental (see issue #43036)
update rust version.
@hadleym please fix Java wrapper too |
double-check Artem's suggestion on Jenkins: yes, with incremented rust version this PR can pass build stage on Jenkins for VCX (jovfer@95b7d2a). |
@jovfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold off on merging this PR until I have had a chance to review it.
@glowkey has found the correct reason for the python segfaults regarding |
Fixes the current libvcx vcx_error_c_message api call. In the current version of vcx_error_c_message, the memory returned via pointer is dropped at the end of the api call, causing undefined behavior when the wrappers dereference the returned pointer.