Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [[deprecated]] in code #1323

Closed
kuvaldini opened this issue Aug 7, 2021 · 1 comment
Closed

Fix [[deprecated]] in code #1323

kuvaldini opened this issue Aug 7, 2021 · 1 comment
Assignees
Labels
iroha1 The legacy version of Iroha.

Comments

@kuvaldini
Copy link
Contributor

kuvaldini commented Aug 7, 2021

git grep -n '\[\[deprecated\]\]'

irohad/model/model_crypto_provider.hpp:17:     * [[deprecated]] Use irohad/crypto_provider with shared_model instead this
irohad/model/model_crypto_provider.hpp:27:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider.hpp:36:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider.hpp:45:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider.hpp:54:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider.hpp:62:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider.hpp:70:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider_impl.hpp:15:    /** [[deprecated]] Use irohad/crypto_provider with shared_model instead this
irohad/model/model_crypto_provider_impl.hpp:21:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider_impl.hpp:27:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider_impl.hpp:33:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider_impl.hpp:39:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider_impl.hpp:45:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider_impl.hpp:51:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/model/model_crypto_provider_impl.hpp:57:       * [[deprecated]] Use irohad/crypto_provider with shared_model instead
irohad/pending_txs_storage/pending_txs_storage.hpp:57:    [[deprecated]] virtual shared_model::interface::types::
libs/common/hexutils.hpp:84:  [[deprecated]] inline boost::optional<std::string> hexstringToBytestring(
shared_model/builders/protobuf/builder_templates/blocks_query_template.hpp:32:    class [[deprecated]] TemplateBlocksQueryBuilder {
shared_model/builders/protobuf/builder_templates/query_template.hpp:39:    class [[deprecated]] TemplateQueryBuilder {
shared_model/builders/protobuf/builder_templates/transaction_template.hpp:38:    class [[deprecated]] TemplateTransactionBuilder {
shared_model/builders/protobuf/transaction_sequence_builder.hpp:22:    class [[deprecated]] TransportBuilder<interface::TransactionSequence, SV> {
shared_model/builders/protobuf/transport_builder.hpp:22:    class [[deprecated]] TransportBuilder {
shared_model/builders/protobuf/unsigned_proto.hpp:25:    class [[deprecated]] UnsignedWrapper {
test/module/shared_model/builders/protobuf/builder_templates/block_template.hpp:34:    class [[deprecated]] TemplateBlockBuilder {
test/module/shared_model/builders/protobuf/builder_templates/proposal_template.hpp:26:    class [[deprecated]] TemplateProposalBuilder {
@kuvaldini
Copy link
Contributor Author

@kamilsa, @iceseer
I do not think it is minor issue. I believe some day, soon day, we will add -Werror -Wextra -Wall.
We have very-very long build listings with [[deprecated]] message.
Let's plan refactoring or just undeprecate abandoned but stable classes and methods.

@kuvaldini kuvaldini self-assigned this Aug 7, 2021
@appetrosyan appetrosyan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2022
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha1 The legacy version of Iroha.
Projects
None yet
Development

No branches or pull requests

3 participants