Support for VCPKG-based Dockerfile on CI #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakhtin
force-pushed
the
feature/vcpkg-dockerfile
branch
2 times, most recently
from
86b13e2
to
3235c47
Compare
bakhtin
changed the title
BulatSaif
reviewed
Jul 16, 2019
| sh("docker pull ${env.DOCKER_REGISTRY_BASENAME}:${imageName} || true") | ||
| randDir = sh(script: "cat /dev/urandom | tr -dc 'a-zA-Z0-9' | head -c 10", returnStdout: true).trim() | ||
| currentDockerfile = utils.getUrl(currentDockerfileURL, "/tmp/${randDir}/currentDockerfile", true) | ||
| referenceDockerfile = utils.getUrl(referenceDockerfileURL, "/tmp/${randDir}/referenceDockerfile") |
There was a problem hiding this comment.
If we push new Dockerfile to master, will it build docker image?
because currentDockerfile and referenceDockerfile will be same.
There was a problem hiding this comment.
Yes, because we always build Docker image regardless of the changes in Dockerfiles:
There was a problem hiding this comment.
It will significantly increase build time?
There was a problem hiding this comment.
It will not since we pull an image first. And in most cases we get 100% cache hit
|
TODO for self: Rename |
lebdron
approved these changes
Jul 24, 2019
BulatSaif
approved these changes
Jul 24, 2019
- Replace older Dockerfile with VCPKG-supported one; - Refactor CI scripts to support building newer Docker images Signed-off-by: Artyom Bakhtin <a@bakhtin.net>
Signed-off-by: Artyom Bakhtin <a@bakhtin.net>
Signed-off-by: Artyom Bakhtin <a@bakhtin.net>
Signed-off-by: Artyom Bakhtin <a@bakhtin.net>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
bakhtin
force-pushed
the
feature/vcpkg-dockerfile
branch
from
97418e8
to
b469af4
Compare
Signed-off-by: Artyom Bakhtin <a@bakhtin.net>
Signed-off-by: Artyom Bakhtin <a@bakhtin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artyom Bakhtin a@bakhtin.net
Description of the Change
:develop-buildimage building strategy. It previously covers the scenario of running several parallel builds on the same agent. This is not true anymore since a build agent spins up exclusively for each build. Thus, the step that checks for differences between current and previous Docker files is no longer required. Previously, it saved some time if multiple builds with analogous changes had been being built on the same agent due to caching.We now only check for changes compared to 'reference' Docker file -- the file in the
masterbranch of the repo. That is to disable build cache for such scenarios to avoid installing system packages from stale APT repositories.ADDinstruction) an image will be built using local cache. That is important since we want to consider changes invcpkgdirectory.jenkinscidirectory andJenkinsfileBenefits
Uniform dependency management across different supported platforms
Possible Drawbacks
None