Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Investigate spurious build failures #3311

Closed
appetrosyan opened this issue Mar 20, 2023 · 4 comments
Closed

[bug]: Investigate spurious build failures #3311

appetrosyan opened this issue Mar 20, 2023 · 4 comments
Labels
Bug Something isn't working build Dev defect The defect was found at the development stage. Did not have an impact on users. iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@appetrosyan
Copy link
Contributor

cargo build from workspace root works. cargo build from dir does not.

Originally posted by @mversic in #3077 (comment)

@appetrosyan appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 20, 2023
@mversic
Copy link
Contributor

mversic commented Mar 21, 2023

If you edit the code in client or client_cli crates to rely on API exposed by the data_model::transparent_api feature the build will be successful if run from workspace root, but will fail if run from the client or client_cli directory. This indicates that when built from workspace root cargo unifies all features.

Expected behavior is that build should fail in all cases because data_model::transparent_api feature is not enabled by the client or client_cli crates.

This behavior can lead to a silent breakage of builds

@Arjentix
Copy link
Contributor

Arjentix commented Apr 26, 2023

To reproduce:

Commit: b185545

  1. cargo check: works (not expected)
  2. cargo run --bin iroha_client_cli: works (not expected)
  3. cargo check --package iroha_client_cli: doesn't work (that's expeced because we really have an error in the code)

@AlexStroke AlexStroke added Bug Something isn't working Dev defect The defect was found at the development stage. Did not have an impact on users. QA-confirmed This bug is reproduced and needs a fix labels Apr 26, 2023
@mversic mversic self-assigned this Sep 22, 2023
@mversic
Copy link
Contributor

mversic commented Sep 22, 2023

related to rust-lang/cargo#4463

@mversic mversic removed their assignment Sep 22, 2023
@mversic
Copy link
Contributor

mversic commented Sep 22, 2023

related to #3423

@mversic mversic closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working build Dev defect The defect was found at the development stage. Did not have an impact on users. iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Development

No branches or pull requests

4 participants