[BUG] kagami genesis synthetic's --assets-per-domain is actually --assets-per-account

[0x009922]

GIT commit hash

5afcdef

Description

Kagami says that you can specify the amount of assets per domain, so the total amount of assets would be:

$$Assets = Domains * AssetsPerDomain$$

kagami help genesis synthetic

 --assets-per-domain <ASSETS_PER_DOMAIN>
          Number of assets per domains in synthetic genesis.
          Total number of assets would be `domains * assets_per_domain`
          
          [default: 0]

But if you look into implementation, you will see that actually it creates $$Assets = Domains * AccountsPerDomain * AssetsPerDomain$$

iroha/tools/kagami/src/main.rs

Lines 448 to 465 in 5afcdef

	let mints = {
	let mut acc = Vec::new();
	for domain in 0..domains {
	for account in 0..accounts_per_domain {
	for asset in 0..assets_per_domain {
	let mint = MintBox::new(
	13_u32.to_value(),
	IdBox::AssetId(AssetId::new(
	format!("asset_{asset}#domain_{domain}").parse()?,
	format!("account_{account}@domain_{domain}").parse()?,
	)),
	);
	acc.push(mint);
	}
	}
	}
	acc
	}

let mints = {
    let mut acc = Vec::new();
    for domain in 0..domains {
        for account in 0..accounts_per_domain {
            for asset in 0..assets_per_domain {
                let mint = MintBox::new(
                    13_u32.to_value(),
                    IdBox::AssetId(AssetId::new(
                        format!("asset_{asset}#domain_{domain}").parse()?,
                        format!("account_{account}@domain_{domain}").parse()?,
                    )),
                );
                acc.push(mint);
            }
        }
    }
    acc
}

So, currently this option is actually not --assets-per-domain, but --assets-per-account.

Expected result

Expected either to have $$Assets = Domains * AssetsPerDomain$$ or to have --assets-per-account option instead.

[Erigara]

@0x009922 currently we have assets definitions per domain, should we rename asset_definitions_per_domain?