Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] kagami - after creating new genesis.json file we have 2 same public keys per user by default #3511

Closed
timofeevmd opened this issue May 22, 2023 · 2 comments · Fixed by #4411
Labels
Bug Something isn't working Dev defect The defect was found at the development stage. Did not have an impact on users. Documentation Documentation changes good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@timofeevmd
Copy link
Contributor

OS and Environment

Docker hub

GIT commit hash

c4af68c

Minimum working example / Steps to reproduce

simple install via docker-compose file

docker-compose -f docker-compose.yml up -d

Actual result

On file /iroha/configs/peer/genesis.json we have a same public key on signatories array

{
          "Register": {
            "NewAccount": {
              "id": "alice@wonderland",
              "signatories": [
                "ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"
              ],
              "metadata": {
                "key": {
                  "String": "value"
                }
              }
            }
          }
        },
        {
          "Register": {
            "NewAccount": {
              "id": "bob@wonderland",
              "signatories": [
                "ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"
              ],
              "metadata": {
                "key": {
                  "String": "value"
                }
              }
            }
          }
        }

Expected result

On file /iroha/configs/peer/genesis.json we have a different public key on signatories array

{
          "Register": {
            "NewAccount": {
              "id": "alice@wonderland",
              "signatories": [
                "ed01204595da8957c5598d4de20fe5f3eb4c14820678e1a1957a535db1fd4b3d1607c5"
              ],
              "metadata": {
                "key": {
                  "String": "value"
                }
              }
            }
          }
        },
        {
          "Register": {
            "NewAccount": {
              "id": "bob@wonderland",
              "signatories": [
                "ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"
              ],
              "metadata": {
                "key": {
                  "String": "value"
                }
              }
            }
          }
        }

Logs in JSON format

Log contents
Replace this text with a JSON log,
so it doesn't grow too large and has highlighting.

Who can help to reproduce?

@timofeevmd

Notes

No response

@timofeevmd timofeevmd added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Documentation Documentation changes labels May 22, 2023
@AlexStroke AlexStroke changed the title [BUG] kogami - after creating new genesis.json file we have 2 same public keys per user by default [BUG] kagami - after creating new genesis.json file we have 2 same public keys per user by default May 22, 2023
@AlexStroke AlexStroke added Dev defect The defect was found at the development stage. Did not have an impact on users. QA-confirmed This bug is reproduced and needs a fix labels May 22, 2023
@mversic
Copy link
Contributor

mversic commented Jun 18, 2023

we actually have three, there is also this:

        "Register": {
          "NewAccount": {
            "id": "carpenter@garden_of_live_flowers",
            "signatories": [
              "ed01207233BFC89DCBD68C19FDE6CE6158225298EC1131B6A130D1AEB454C1AB5183C0"
            ],
            "metadata": {}
          }
        }

@mversic mversic added the good first issue Good for newcomers label Oct 31, 2023
@mversic mversic removed their assignment Nov 16, 2023
@mversic mversic closed this as completed Apr 24, 2024
@mversic
Copy link
Contributor

mversic commented Apr 24, 2024

will be resolved by #2085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Dev defect The defect was found at the development stage. Did not have an impact on users. Documentation Documentation changes good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants