Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Upgrade::new into Upgrade::executor #4511

Open
mversic opened this issue Apr 25, 2024 · 1 comment
Open

Rename Upgrade::new into Upgrade::executor #4511

mversic opened this issue Apr 25, 2024 · 1 comment
Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Apr 25, 2024

Upgrade::new is very vague. Either rename it into Upgrade::executor or UpgradeExecutor::new.
The assumption here is that there will be other things to upgrade, not only executor. Is this correct?
@mversic mversic added api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 25, 2024
@nxsaken nxsaken added the good first issue Good for newcomers label May 14, 2024
@PanGan21
Copy link

Hi is this issue still open to contributions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nxsaken @mversic @PanGan21