Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Iroha - start Torii with all other tasks #4562

Closed
0x009922 opened this issue May 7, 2024 · 0 comments · Fixed by #4699
Closed

Refactor Iroha - start Torii with all other tasks #4562

0x009922 opened this issue May 7, 2024 · 0 comments · Fixed by #4699
Assignees
Labels
Refactor Improvement to overall code quality

Comments

@0x009922
Copy link
Contributor

0x009922 commented May 7, 2024

          I feel strange that torii is used to "block" iroha.

Imo it would be simpler design if iroha would always spawn torii in sparate task as any other service.

And on iroha start we would just listen on notify_sender:

async fn start(self) {
    self.notify_sender.notified().await    
}

This way iroha user is free to either block on this and wait on shutdown or start it as task.

Originally posted by @Erigara in #4456 (comment)

@0x009922 0x009922 added Refactor Improvement to overall code quality iroha2 labels May 7, 2024
@nxsaken nxsaken removed the iroha2 label May 17, 2024
@Erigara Erigara self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants