Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Instruction for *Box wrappers #4704

Open
nxsaken opened this issue Jun 6, 2024 · 2 comments
Open

Implement Instruction for *Box wrappers #4704

nxsaken opened this issue Jun 6, 2024 · 2 comments
Labels
Enhancement New feature or request good first issue Good for newcomers

Comments

@nxsaken
Copy link
Contributor

nxsaken commented Jun 6, 2024

Currently, only InstructionBox implements Instruction out of all ISI wrappers. I expected RegisterBox, MintBox and the rest of the wrappers to be usable with iroha.submit_*() directly, but they are not. I think it would be more ergonomic if they were.

@nxsaken nxsaken added Enhancement New feature or request good first issue Good for newcomers labels Jun 6, 2024
@mversic
Copy link
Contributor

mversic commented Jun 14, 2024

related to #4703

@nxsaken
Copy link
Contributor Author

nxsaken commented Jul 1, 2024

Additionally, change instances of impl IntoIterator<Item = impl Instruction> function parameters to impl IntoIterator<Item = I>, I: Instruction, which is more flexible due to the turbofish syntax being available. This would allow wrapping multiple instructions into *Boxes without binding them to a separate variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants