This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Validate failure on invalid STREAM frames #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a particular frame in a StreamPacket cannot be decoded for whatever reason, we should skip that frame but otherwise keep trying to decode frames. Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
…valid-stream-frames Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # codecs-parent/codecs-stream/src/test/java/org/interledger/codecs/stream/StreamPacketFixturesTest.java
sappenin
changed the title
sappenin
changed the title
Signed-off-by: David Fuelling <sappenin@gmail.com>
nhartner
approved these changes
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a particular frame in a StreamPacket cannot be decoded for whatever reason, we should not swallow exception. See comments in unit test code for rationale.
Fixes #455
Signed-off-by: David Fuelling sappenin@gmail.com