This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
[Backport 1.1] Parent not found when trying to delete & update simultaneously #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsulegai
force-pushed
the
backport-branch
branch
from
8f8a80a
to
ba5ed5c
Compare
|
@agunde406 @rberg2 I cherry-picked the lint fixes from #2257 to this backport PR. @rberg2 1237dcc looks suspicious to me. Please confirm if no issues were reported after this change. |
arsulegai
force-pushed
the
backport-branch
branch
from
ba5ed5c
to
19ca5ce
Compare
Unnecessary use of a comprehension Signed-off-by: Andrea Gunderson <agunde@bitwise.io> Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Unnecessary "else" after "continue" or "break" Signed-off-by: Andrea Gunderson <agunde@bitwise.io> Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Unnecessary use of a comprehension Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Unnecessary use of a comprehension Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Positional arguments appear to be out of order (arguments-out-of-order) Signed-off-by: Richard Berg <rberg@bitwise.io> Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Using subprocess.run without explicitly set `check` is not recommended. (subprocess-run-check) Signed-off-by: Richard Berg <rberg@bitwise.io> Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Consider using sys.exit() (consider-using-sys-exit) Signed-off-by: Richard Berg <rberg@bitwise.io> Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Before when the args were in the wrong order this pylint issues did not get raised. After that was fixed, useless-super-delegation issues was rasied. This is ignored because the parrent is an abstract class. Signed-off-by: Andrea Gunderson <agunde@bitwise.io> Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Signed-off-by: Andrea Gunderson <agunde@bitwise.io> Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Unnecessary use of a comprehension Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Using subprocess.run without explicitly set `check` is not recommended. (subprocess-run-check) Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Unnecessary use of a comprehension Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
Transaction is submitted to handle simultaneous read and write to multiple addresses in merkle tree. "merkle_db_update" is called with both update items and delete items. If update items have common parent with delete items, and delete items remove common parent required by update items a node is left to be added without a correct parent chain. Processing delete items leaves behind the broken parent chain. Solution: Remove parent node of item to be deleted only if its path is not in parent chain of update items. Signed-off-by: S m, Aruna <aruna.mohan@walmartlabs.com>
arsulegai
force-pushed
the
backport-branch
branch
from
19ca5ce
to
67bdb25
Compare
|
This PR could be facing the issue discussed here pylint-dev/pylint#3312 |
|
I see that when build passed pylint's version was 2.4.4 but now pylint is pegged to version 2.3.1. That is causing the issue. |
|
Closing this backport PR as we are not anticipating any further 1.1.x releases. If this is an error (we need a future 1.1 release with this change), let's discuss. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction is submitted to handle simultaneous read and write
to multiple addresses in merkle tree.
"merkle_db_update" is called with both update items and delete
items. If update items have common parent with delete items,
and delete items remove common parent required by update items a
node is left to be added without a correct parent chain.
Processing delete items leaves behind the broken parent chain.
Solution: Remove parent node of item to be deleted only if its
path is not in parent chain of update items.
This is a backport from #2000
There are also additional lint fix commits, some of which are cherry-pick from #2257