Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Fix/build dockerfiles #33

Closed
wants to merge 2 commits into from
Closed

Fix/build dockerfiles #33

wants to merge 2 commits into from

Conversation

daverodz
Copy link

No description provided.

Signed-off-by: Andrew Donald Kennedy <andrew.kennedy@cloudsoftcorp.com>
Signed-off-by: Andrew Donald Kennedy <andrew.kennedy@cloudsoftcorp.com>
@vaporos vaporos self-requested a review June 2, 2018 05:10
Copy link
Contributor

@vaporos vaporos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any copyright changes need further discussion and consensus of (at least) all the maintainers and maybe the Sawtooth root team.

Are the non-copyright changes in this PR still valid? If so, please rebase to resolve conflicts and remove the copyright changes.

@dcmiddle
Copy link
Contributor

dcmiddle commented Jun 2, 2018

I'm fine with changing the banner to be Copyright Hyperledger Sawtooth Contributors. As I understand it from the Linux Foundation staff, banners aren't actually copyright indications but are meant to facilitate tracking back to the license when the files are copied outside the project.
It should generally be the original person who initially created the banner who changes it. In this case I'm not concerned so long as we change it from "Hyperledger Foundation" (which isn't a thing) to "Hyperledger Sawtooth Contributors".

@knkski
Copy link
Contributor

knkski commented Aug 27, 2018

@daverodz / @dcmiddle: With #62 merged, is there any reason to keep this PR around or can we close it?

@knkski
Copy link
Contributor

knkski commented Aug 28, 2018

Closing due to inactivity. Feel free to reopen rebased off of master to fix conflicts

@knkski knkski closed this Aug 28, 2018
@knkski knkski deleted the fix/build-dockerfiles branch August 28, 2018 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants