seth account create myalias --wait causes segmentation violation #37
Conversation
After starting up seth, during account creation segmentation violation occurs. Resolves: STL-1241 Signed-off-by: mithunshashidhara <mithunx.shashidhara@intel.com>
mithunshashidhara
force-pushed
the
STL-1241
branch
from
b180963
to
6f516a4
Compare
|
corrected file permissions, please check. |
| @@ -81,7 +81,8 @@ func (args *AccountCreate) Run(config *Config) error { | |||
| if args.Nonce == "" { | |||
| nonce, err = client.LookupAccountNonce(priv) | |||
| if err != nil { | |||
| return err | |||
| nonce = 0 | |||
There was a problem hiding this comment.
This hides any other error message that would come from client.LookupAccountNonce. We need to check the Account.Nonce value in client.LookupAccountNonce and make sure that a valid value is returned instead of nil
There was a problem hiding this comment.
there are log messages inside client.LookupAccountNonce for all the error scenarios that i have encountered so far, only when account creation nonce is not generated from rest-api, in other scenarios i do see nonce. this was the only solution i could come up with.
| if body.Data == nil { | ||
| err := fmt.Errorf("Rest API GET received improper response") | ||
| return nil, err | ||
| } else { |
There was a problem hiding this comment.
Is this still fixing the same problem?
There was a problem hiding this comment.
yes, its the same problem which you had commented earlier, sorry i messed up git during update of commit, so i created a new PR
There was a problem hiding this comment.
@knkski yes this issue is fixed, i will close this PR, Thanks
|
@mithunshashidhara: This should've been fixed by #42. Are you still encountering this issue? |
|
reported issue fixed in PR #42 |
After starting up seth, during account creation
segmentation violation occurs.
Resolves: STL-1241
Signed-off-by: mithunshashidhara mithunx.shashidhara@intel.com