This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Update Docker Compose File for seth-rpc Service
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! You will need to sign off on your commit in order for it to get built. You can find more info on that here: Contributing |
dplumb94
requested review from
vaporos,
dplumb94,
grkvlt,
peterschwarz and
aludvik
and removed request for
vaporos
ksolo
force-pushed
the
docker-compose-updates-for-seth-rpc
branch
from
a924ed8
to
07a14f8
Compare
|
@dplumb94 Thanks for taking a look. I updated the commit to include the sign-off. Let me know if anything else is needed. |
dplumb94
approved these changes
Jul 6, 2018
Signed-off-by: Kevin Solorio <soloriok@gmail.com>
ksolo
force-pushed
the
docker-compose-updates-for-seth-rpc
branch
from
07a14f8
to
00bfc79
Compare
|
@knkski rebased and pushed up. |
vaporos
approved these changes
Jul 10, 2018
|
@knkski Pretty sure the underlying bug was fixed and this PR can be squashed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
The
seth-rpcservice was failing to start due to the first portion of the command in the docker-compose file. This was causing thecurlcommands to fail.WHAT
Removing the
seth initcall with compose already running allowed the curl commands to complete as expected when following the developer guides.