This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Handle nonce-less account creation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumb94
requested review from
dplumb94,
aludvik,
grkvlt,
peterschwarz,
vaporos,
boydjohnson,
jsmitchell,
agunde406 and
askmish
dplumb94
approved these changes
Jul 6, 2018
When attempting to grab the nonce associated with an account during account creation, `Client.Get` will return `nil, nil` due to the account not yet existing. This PR updates `Client.LookupAccountNonce` to handle that scenario and default to `0` for the nonce instead. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
aludvik
approved these changes
Jul 10, 2018
vaporos
approved these changes
Jul 10, 2018
knkski
pushed a commit
to knkski/sawtooth-seth
that referenced
this pull request
Jul 11, 2018
This PR is a followup on hyperledger-archives#42, and adds an integration test to prevent a regression. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
Merged
knkski
pushed a commit
to knkski/sawtooth-seth
that referenced
this pull request
Jul 12, 2018
This PR is a followup on hyperledger-archives#42, and adds an integration test to prevent a regression. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
knkski
pushed a commit
to knkski/sawtooth-seth
that referenced
this pull request
Jul 12, 2018
This PR is a followup on hyperledger-archives#42, and adds an integration test to prevent a regression. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to grab the nonce associated with an account during account creation,
Client.Getwill returnnil, nildue to the account not yet existing. This PR updatesClient.LookupAccountNonceto handle that scenario and default to0for the nonce instead.Signed-off-by: Kenneth Koski knkski@bitwise.io