This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Share key dir between cli and rpc containers #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knkski
force-pushed
the
sharing-key-dir
branch
4 times, most recently
from
1116961
to
1d68042
Compare
knkski
commented
Jul 10, 2018
docker-compose.yaml
Outdated
| depends_on: | ||
| - validator | ||
| ports: | ||
| - 3030:3030 | ||
| command: | | ||
| bash -c " | ||
| seth init http://rest-api:8080 && |
There was a problem hiding this comment.
Note that this change will disappear after #38 is merged and this PR is rebased
knkski
force-pushed
the
sharing-key-dir
branch
4 times, most recently
from
dc8ea49
to
be824a2
Compare
dplumb94
requested review from
dplumb94,
aludvik,
vaporos,
grkvlt,
peterschwarz and
jsmitchell
and removed request for
aludvik
knkski
force-pushed
the
sharing-key-dir
branch
3 times, most recently
from
6648950
to
0686d39
Compare
The Seth RPC container relies on keys that were generated by the CLI. Previously, we were generating those keys inside of the RPC container with a CLI call. This PR moves to sharing a key directory between the CLI and RPC containers, with the CLI container generating the keys in that directory. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
aludvik
approved these changes
Jul 16, 2018
dplumb94
approved these changes
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Seth RPC container relies on keys that were generated by the CLI. Previously, we were generating those keys inside of the RPC container with a CLI call. This PR moves to sharing a key directory between the CLI and RPC containers, with the CLI container generating the keys in that directory.
Remix of #28. This PR punts on the issue of using
SAWTOOTH_HOME/SAWTOOTH_KEYSenvironment variables as per #28 (comment). It also switches from aget_data_dirto aget_key_dir, asget_data_diris then otherwise unused apart fromget_key_dir.Signed-off-by: Kenneth Koski knkski@bitwise.io